Skip to content

Comments

[PW_SID:1055840] use runtime constant to optimize handle_arch_irq access#1482

Open
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1055840
Open

[PW_SID:1055840] use runtime constant to optimize handle_arch_irq access#1482
linux-riscv-bot wants to merge 3 commits intoworkflow__riscv__fixesfrom
pw1055840

Conversation

@linux-riscv-bot
Copy link

PR for series 1055840 applied to workflow__riscv__fixes

Name: use runtime constant to optimize handle_arch_irq access
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1055840
Version: 1

We will use the runtime constant to optimize the handle_arch_irq
accessing. This is preparation patch.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Currently, on GENERIC_IRQ_MULTI_HANDLER platforms, the handle_arch_irq
is a pointer which is set during booting, and every irq processing needs
to access it, so it sits in hot code path. We can use the
runtime constant mechanism which was introduced by Linus to speed up
its accessing.

Tested on Sipeed Lichee Pi 4A (riscv64) board, the perf sched benchmark is
improved by ~5.8%

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Currently, on arm64 platforms, the handle_arch_irq is a pointer which
is set during booting, and every irq processing needs to access it,
so it sits in hot code path. We can use the runtime constant mechanism
which was introduced by Linus to speed up its accessing.

Tested on Quad CA55 platform, the perf sched benchmark is improved
by ~6.5%

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 143.12 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1158.95 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1658.83 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 29.44 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 31.05 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.02 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 86.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.24 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
kdoc
Desc: Detects for kdoc errors
Duration: 0.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
module-param
Desc: Detect module_param changes
Duration: 0.26 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "[1/3] vmlinux.lds.h: add _handle_arch_irq RUNTIME_CONST section"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.31 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 142.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1864.41 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 2594.01 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 28.82 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 29.80 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.16 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 85.79 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
kdoc
Desc: Detects for kdoc errors
Duration: 1.01 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.21 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 2: "[2/3] genirq: use runtime constant to optimize handle_arch_irq access"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 141.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1020.93 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1362.47 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 28.66 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 30.11 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 1.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 86.51 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
kdoc
Desc: Detects for kdoc errors
Duration: 1.01 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
module-param
Desc: Detect module_param changes
Duration: 0.25 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 3: "[3/3] arm64: use runtime constant to optimize handle_arch_irq access"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.29 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants